schedule: rename ll_schedule.c to ll_schedule_xtos.c #10507
Conversation
The scheduler implementation in ll_schedule.c implements a low-latency (LL) scheduler using old XTOS interfaces. The code has been modified so it can be used with Zephyr using the SOF rtos/ interface. The code is only used by one build target at this point and it should not be used for new targets. To make it clear this is not the primary implementation, rename the file with a "xtos" postfix. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
requested review from
LaurentiuM1234,
dbaluta,
marcinszkudlinski and
pblaszko
as code owners
There was a problem hiding this comment.
Pull request overview
This PR renames the low-latency scheduler implementation file from ll_schedule.c to ll_schedule_xtos.c to clearly indicate that it uses legacy XTOS interfaces and is not the primary implementation for new targets.
Changes:
- Renamed
ll_schedule.ctoll_schedule_xtos.cto reflect its XTOS-specific nature - Updated the CMake build configuration to reference the renamed file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lyakh
left a comment
lyakh
left a comment
There was a problem hiding this comment.
a good idea in principle, but for a reader today the name wouldn't tell much? Which target(s) still use(s) it? Cmocka or something? Maybe ll_schedule_test.c or ll_schedule_legacy.c or move it to the respective directory?
| else() | ||
| zephyr_library_sources( | ||
| ll_schedule.c | ||
| ll_schedule_xtos.c |
There was a problem hiding this comment.
Both "xtos" and "legacy" are fine to use, although "xtos" is more common here.
But I'm not sure if building the xtos version from the main branch is still possible? Even build scripts like xtensa-build-all.sh were removed.
There was a problem hiding this comment.
good point @abonislawski , xtos version should no longer be buildable but IIRC there are some lingering headers that have to be removed before all xtos file can go completely.
There was a problem hiding this comment.
@abonislawski @lgirdwood This is only used by AMD ACP6.0 build target (CONFIG_SOC_ACP_6_0), and when it's build without DMA scheduling. This is a Zephyr build, so not sure how this works, but SOF did provide migration tools to run XTOS code over Zephyr like this. I'm not sure if this is actively used, but the build target exists, so I don't want to remove the file.
I picked the "_xtos" prefix as then it's easier to note and remember to remember when we drop this target.
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
Btw, what the last xtos platform ?
4 participants
The scheduler implementation in ll_schedule.c implements a low-latency (LL) scheduler using old XTOS interfaces. The code has been modified so it can be used with Zephyr using the SOF rtos/ interface.
The code is only used by one build target at this point and it should not be used for new targets. To make it clear this is not the primary implementation, rename the file with a "xtos" postfix.